Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-377 surplus properties style update #1938

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

TaylorFries
Copy link
Collaborator

@TaylorFries TaylorFries commented Nov 27, 2023

🎯 Summary

PIMS-377:

Updating Surplus Properties Overlay to not overlap map controls when open.

Previous view:

Screenshot 2023-11-27 at 1 21 07 PM

New view:

Screenshot 2023-11-27 at 1 21 19 PM

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The APP Image has been built with the tag: 1938. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Nov 27, 2023

Code Climate has analyzed commit feb9f26 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.8%.

View more on Code Climate.

Copy link
Collaborator

@Sharala-Perumal Sharala-Perumal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user can access the map controls on home page as well as click on the property folders on the View Inventory page. No console errors.

@TaylorFries TaylorFries self-assigned this Nov 28, 2023
@TaylorFries TaylorFries merged commit 0c2177a into main Nov 28, 2023
5 checks passed
@TaylorFries TaylorFries deleted the PIMS-377-surplus-properties-style-update branch November 28, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants