Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-370 Remove Border & other styling updates #1943

Merged
merged 14 commits into from
Nov 30, 2023
Merged

Conversation

TaylorFries
Copy link
Collaborator

@TaylorFries TaylorFries commented Nov 28, 2023

🎯 Summary

PIMS-370:

Updated tabs on Associated Land Form to remove border.
Moved all styling from SteppedForm.tsx to SteppedForm.scss and wrote descriptions for class names when not clear what they are set to format.

Areas affected by these changes:

  • Land Association Form (select building -> edit -> modify associated land)
  • Land Search Form (select "Submit Property tab -> fill out form)
  • Land Form (select parcel -> edit_
  • these are the only fields I have noted that get changed, if there are others please test them to ensure changes do not negetivly affect them.

Previous formatting:

Screenshot 2023-11-28 at 9 22 43 AM

New formatting:

Screenshot 2023-11-28 at 9 27 54 AM

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The APP Image has been built with the tag: 1943. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Nov 28, 2023

Code Climate has analyzed commit 8f56e18 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.8%.

View more on Code Climate.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor changes to keep tab margins and font colour consistent.
Looks good otherwise.

@TaylorFries TaylorFries merged commit d5720db into main Nov 30, 2023
5 checks passed
@TaylorFries TaylorFries deleted the PIMS-370-remove-border branch November 30, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants