PIMS-526: Upload Properties failing when Location doesn't exist #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployment Information The APP Image has been built with the tag: |
LawrenceLau2020
commented
Dec 6, 2023
| @@ -104,6 +106,8 @@ export const UploadProperties: React.FC = () => { | |||
| setPhase(UploadPhase.FILE_SELECT); | |||
| }; | |||
|
|
|||
| // Fetch existingAdminAreas using useCodeLookups | |||
| const lookupCodes = useCodeLookups(); | |||
There was a problem hiding this comment.
I couldn't seem to get this useCodeLookups() hook to work inside the csvToPropertyModel.ts
LawrenceLau2020
commented
Dec 6, 2023
| (property: IExportedPropertyModel) => { | ||
| const city = existingAdminAreas.some((adminArea) => adminArea.name === property.Location) | ||
| ? property.Location || '' | ||
| : getValueOrDefault(property['Regional District'], ''); |
There was a problem hiding this comment.
Use the value from the Location column of the spreadsheet if it exists in the administrative areas in PIMS, if not then use the value from the Regional District column.
|
There was no issue with the upload feature, was a container issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Summary
PIMS-526:
Did some refactoring to check admin areas before sending to api, for some reason was getting a bunch of "Administrative area 'xxxxx' does not exist in the datasource".
This PR is a work in progress to see if we can simplify what needs to be fixed.
🔰 Checklist