Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-388 Express Linting Workflow #1966

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-388

Provides a linting workflow that should run when PRs are opened or synchronized.
If there are linting errors, the workflow check will fail.

Had to make some linting updates for errors that already existed.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Dec 7, 2023
@dbarkowsky dbarkowsky marked this pull request as ready for review December 7, 2023 21:26
Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow runs as expected and no linting errors on this branch.

Copy link

codeclimate bot commented Dec 12, 2023

Code Climate has analyzed commit 61f6d5a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.

@dbarkowsky dbarkowsky merged commit 82d33ba into main Dec 12, 2023
3 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-388-Express-Linting-Workflow branch December 12, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants