-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-400 Install TypeORM #1971
PIMS-400 Install TypeORM #1971
Conversation
Code Climate has analyzed commit fd4fd16 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent, does this file work as appDataSource? Camel case vs kebab case.
I realize that heath-router exists, but that should have been healthRouter probably too.
Co-authored-by: Dylan Barkowsky <37922247+dbarkowsky@users.noreply.github.com>
synchronize: true, | ||
migrationsRun: false, | ||
logging: true, | ||
logger: new CustomWinstonLogger(true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does true
argument do? I can't find documentation on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to find the link again but couldn't - there are cases (in stackoverflow) where not passing in 'true' means that the custom logger never initializes and then throws an error when it is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contents have changed. Will re-review when ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran in local with npm run dev
and in container. Database connects successfully. Approved again.
🎯 Summary
PIMS-400:
Adding the foundation for TypeORM to be used in express-api
Changes include:
To test:
🔰 Checklist