Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-624 Frontend Keycloak #2006

Merged
merged 4 commits into from
Jan 3, 2024
Merged

PIMS-624 Frontend Keycloak #2006

merged 4 commits into from
Jan 3, 2024

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-624

Changes

  • Added Keycloak package from IMB repo
  • Added react-router-dom and files for Home and Login pages
  • Included some buttons to test login/logout

Documentation on Keycloak package here:
https://github.com/bcgov/citz-imb-kc-react

Testing

  1. Populate the root .env file with the Keycloak options. They are not the same as the old ones. Find them under the development JSON in the new integration, or ask for them from me directly.
image
  1. Make sure both the express-api and the new react-app frontend are running locally.
  2. Should be able to log in and out using your IDIR. I have it set to Azure IDIR for now, instead of just IDIR. This was the recommendation on Keycloak, because it offers MFA options.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Jan 3, 2024
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, was able to authenticate using regular IDIR.

@dbarkowsky dbarkowsky merged commit 9ae75fe into main Jan 3, 2024
1 check passed
@dbarkowsky dbarkowsky deleted the PIMS-624-Frontend-Keycloak branch January 3, 2024 19:47
TaylorFries pushed a commit that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants