Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-620 Frontend Testing Addition #2028

Merged
merged 7 commits into from
Jan 12, 2024
Merged

PIMS-620 Frontend Testing Addition #2028

merged 7 commits into from
Jan 12, 2024

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Jan 11, 2024

🎯 Summary

PIMS-610

Changes

  • Adds a testing framework to the new react-app component.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Jan 11, 2024
@dbarkowsky
Copy link
Collaborator Author

Some current issues:

  1. Image imports seem to fail. I've tried mocking any svg or png types that are imported using the path mapping, but it doesn't seem to pick those up.
  2. The .css imports seem to cause rendering issues as well.
  3. For some reason, .inTheDocument() is not recognized for me.

… component so that it will be rendered correrctly, disabled prettier for jest
@GrahamS-Quartech
Copy link
Contributor

These tests should be good to go now. I don't have the image import issue but css imports are fixed now. .inTheDocument was being overwritten by importing describe, etc for jest it seems. Note that prettier v3 is unsupported for jest apparently, so I've just disabled it. Don't think this matters but figured I'd mention it.

@dbarkowsky dbarkowsky merged commit f5085e7 into main Jan 12, 2024
2 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-620 branch January 12, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants