Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-661: Access Pending #2030

Merged
merged 9 commits into from
Jan 15, 2024
Merged

PIMS-661: Access Pending #2030

merged 9 commits into from
Jan 15, 2024

Conversation

GrahamS-Quartech
Copy link
Contributor

🎯 Summary

PIMS-661

  • Added a new component to the access request page to show after form submission but before approval.
  • Refactored the access request page a bit to make it easy to swap between displaying the form or the pending notice.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page looks nice.
I suppose we should start making service tickets so there are some access request endpoints to use for state management here.

react-app/src/pages/AccessRequest.tsx Show resolved Hide resolved
@GrahamS-Quartech GrahamS-Quartech merged commit a67b1a6 into main Jan 15, 2024
2 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-661-Access-Pending branch January 15, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants