Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-722-Hide-Subdivision-Feature #2111

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-722

Temporary measure to hide the option to create subdivisions when submitting new properties.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The APP Image has been built with the tag: 2111. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Jan 24, 2024

Code Climate has analyzed commit 4f944e8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.8%.

View more on Code Climate.

@dbarkowsky
Copy link
Collaborator Author

dbarkowsky commented Jan 24, 2024

Please hold to merge. Checking with Josh

Decided to only hide button for those without some sort of admin role. It seems to only be SRES that uses it, so maybe that's best for now.

Copy link
Contributor

@GrahamS-Quartech GrahamS-Quartech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean solution 👍

@dbarkowsky dbarkowsky merged commit 21c0465 into main Jan 25, 2024
5 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-722-Hide-Subdivision-Feature branch January 25, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants