-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1805: Disposal project property search constraints #2486
Conversation
🚀 Deployment Information The Express API Image has been built with the tag: |
Code Climate has analyzed commit 07b9724 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 80.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 93.2%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well for me. As a general user, only properties from my agencies appear in the fuzzy search list.
🎯 Summary
PIMS-1805:
Changes
Adding restrictions on property search in projects so that "General Users" should only be able to add their own agency's properties, while administrators can add a property from any agency to a project.
Only properties that are in "Surplus Active" or "Surplus Encumbered" classification can be added.
I needed to change the propertiesFuzzySearch, so hoping this doesn't break anything.
Testing
🔰 Checklist