Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1821: Fixing agency filtering on properties and projects #2488

Merged
merged 34 commits into from
Jul 5, 2024

Conversation

LawrenceLau2020
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 commented Jun 27, 2024

🎯 Summary

PIMS-1821:

Changes

  • Moved getProjects to use querybuilder instead of .find. Needed to get both AND and OR nested WHERE options.

Issues

  • Status isn't seen as a valid alias for filtering. Works for sorting though, but trying to filter on any field created by a join seems to crash it.
    • It's not clear what it wants for the Status alias.
    • Would it be easier to just make a view for this table? Then no joins in query.
  • Preset filters (from the dropdown) not working as expected, especially when setting it to the all option.
  • Using column filter with quicksearch filter overwrites the first filter. This makes it possible to search for records that should be omitted based on the other filter.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2488. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Jul 2, 2024

Code Climate has analyzed commit 55c4ae0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.2%.

View more on Code Climate.

@TaylorFries

This comment was marked as outdated.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double filtering works as expected on projects and inventory.

@GrahamS-Quartech GrahamS-Quartech merged commit a1744bb into main Jul 5, 2024
8 of 9 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1821 branch July 5, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants