psp-8438 | Complementary UI for file headers + zoom to property fix #4020
Conversation
|
✅ No secrets were detected in the code. |
|
Looks like this change skipped the right hand side of the project screen:
The following visual changes have been made to all the other headers (i.e. property, project, research, disposition, acquisition) |
| @@ -55,59 +53,35 @@ export const LeaseHeader: React.FC<ILeaseHeaderProps> = ({ lease, lastUpdatedBy | |||
| /> | |||
| </HeaderField> | |||
| <Row> | |||
| <HeaderLabelCol label="Start date:" labelWidth="3" /> | |||
| <HeaderLabelCol label="Lease Start:" labelWidth="3" /> | |||
There was a problem hiding this comment.
Hmm, I don't see this requirement in the story. Why is this here?
| <HeaderContentCol contentWidth="3"> | ||
| {prettyFormatDate(lease?.startDate)} | ||
| </HeaderContentCol> | ||
| <HeaderLabelCol label="Expiry date:" /> | ||
| <HeaderLabelCol label="Expiry:" /> |
| @@ -53,7 +53,7 @@ const ResearchHeader: React.FunctionComponent< | |||
| <Col xs={leftColumnWidth}> | |||
| <Row className="no-gutters"> | |||
| <Col> | |||
| <HeaderField label="File #:" labelWidth={leftColumnLabel} contentWidth="9"> | |||
| <HeaderField label="File:" labelWidth={leftColumnLabel} contentWidth="9"> | |||
There was a problem hiding this comment.
I don't see this requested in the story either.
| @@ -67,7 +67,7 @@ const ResearchHeader: React.FunctionComponent< | |||
| </Row> | |||
| <Row className="no-gutters"> | |||
| <Col> | |||
| <HeaderField label="MoTI region:" labelWidth={leftColumnLabel} contentWidth="9"> | |||
| <HeaderField label="MOTI region:" labelWidth={leftColumnLabel} contentWidth="9"> | |||
There was a problem hiding this comment.
Part of the mockup
| import { ApiGen_Concepts_HistoricalFileNumber } from '@/models/api/generated/ApiGen_Concepts_HistoricalFileNumber'; | ||
| import { exists } from '@/utils'; | ||
|
|
||
| export interface IHistoricalNumbersViewProps { | ||
| historicalNumbers: ApiGen_Concepts_HistoricalFileNumber[]; | ||
| } | ||
|
|
||
| interface HistoricalGroup { |
There was a problem hiding this comment.
Hmm, why does this PR contain changes to the historical file numbers logic?
There was a problem hiding this comment.
Because this PR is a branch from an earlier PR (lease header updates). Once merged, the change set here will be quite small
This is dependant on the earlier PR that addresses the lease changes. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
No description provided.