Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2641 - Award Configurations - PT BCAG (Net) Quick Fix #2680

Merged
merged 1 commit into from
Jan 17, 2024
Merged

#2641 - Award Configurations - PT BCAG (Net) Quick Fix #2680

merged 1 commit into from
Jan 17, 2024

Conversation

lewischen-aot
Copy link
Collaborator

  • removed console.log(calculatedAssessment.variables); from test files

@lewischen-aot lewischen-aot self-assigned this Jan 13, 2024
@lewischen-aot lewischen-aot force-pushed the fix/#2641-award-configurations-pt-bcag-net branch from b1fe4c2 to ccc3b1d Compare January 17, 2024 17:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 19.52% ( 2659 / 13621 )
Methods: 10.32% ( 179 / 1734 )
Lines: 22.16% ( 2288 / 10327 )
Branches: 12.31% ( 192 / 1560 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 51.87% ( 360 / 694 )
Methods: 46.15% ( 42 / 91 )
Lines: 56.52% ( 299 / 529 )
Branches: 25.68% ( 19 / 74 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 78.26% ( 673 / 860 )
Methods: 71.84% ( 74 / 103 )
Lines: 79.97% ( 587 / 734 )
Branches: 52.17% ( 12 / 23 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 55.43% ( 4139 / 7467 )
Methods: 52.2% ( 511 / 979 )
Lines: 60.08% ( 3348 / 5573 )
Branches: 30.6% ( 280 / 915 )

@lewischen-aot lewischen-aot marked this pull request as ready for review January 17, 2024 18:20
sh16011993
sh16011993 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

andrepestana-aot
andrepestana-aot approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lewischen-aot lewischen-aot merged commit 9b6940a into main Jan 17, 2024
18 checks passed
dheepak-aot
dheepak-aot reviewed Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍

@lewischen-aot lewischen-aot deleted the fix/#2641-award-configurations-pt-bcag-net branch January 17, 2024 19:04
guru-aot
guru-aot reviewed Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guru-aot guru-aot guru-aot left review comments

@dheepak-aot dheepak-aot dheepak-aot left review comments

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@sh16011993 sh16011993 sh16011993 approved these changes

@andrewsignori-aot andrewsignori-aot Awaiting requested review from andrewsignori-aot

Assignees

@lewischen-aot lewischen-aot

Labels
E2E/Unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lewischen-aot @sh16011993 @dheepak-aot @guru-aot @andrepestana-aot