Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Decisions + Add Copying #1089

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Update Decisions + Add Copying #1089

merged 1 commit into from
Oct 25, 2023

Conversation

dhaselhan
Copy link
Collaborator

  • Remove certain outcomes
  • Remove linked outcome resolution for App Decisions
  • Add ability and unit tests for copying an existing decision

sandratoh
sandratoh approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@sandratoh sandratoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one nitpick comment but LGTM 👍

...tice-of-intent-decision/notice-of-intent-decision-v2/notice-of-intent-decision-v2.service.ts
const oldUuid = newToOldComponentsUuid.get(component.uuid);
return (
!!oldUuid &&
conditionsComponents &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Do we need && conditionsComponents? Application service doesn't have it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the slight difference between using ! and using ? on the .components of the decision. I've changed them both to use ? so that they at least match.

Update Decisions + Add Copying
08a9147 
* Remove certain outcomes
* Remove linked outcome resolution for App Decisions
* Add ability and unit tests for copying an existing decision
@dhaselhan dhaselhan merged commit 10bbd1b into develop Oct 25, 2023
3 checks passed
@dhaselhan dhaselhan deleted the feature/ALCS-1146 branch October 25, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandratoh sandratoh sandratoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaselhan @sandratoh