Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Portal Decisions #1093

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Update Portal Decisions #1093

merged 2 commits into from
Oct 26, 2023

Conversation

dhaselhan
Copy link
Collaborator

  • Replace outcome -> description
  • Update file listing to new UX
  • Select last tab if app is in final status
  • Map fileSize as it was not sent previously
  • Repeat a bunch of times for each page

Update Portal Decisions
4ff0c51 
* Replace outcome -> description
* Update file listing to new UX
* Select last tab if app is in final status
* Map fileSize as it was not sent previously
* Repeat a bunch of times for each page
Code Review Feedback
88409a0 
* Fix up some incorrect types on NOIs
sandratoh
sandratoh approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@sandratoh sandratoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dhaselhan dhaselhan merged commit 0003322 into develop Oct 26, 2023
3 checks passed
@dhaselhan dhaselhan deleted the feature/ALCS-1203-2 branch October 26, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandratoh sandratoh sandratoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaselhan @sandratoh