Add Covenant Proposal Step #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dhaselhan
commented
Oct 30, 2023
dhaselhan
commented
- Add Covenant Transferees
- Add the other stuff
* Add Covenant Transferees * Add the other stuff
mhuseinov
approved these changes
Oct 30, 2023
| <span *ngIf="_applicationSubmission.coveFarmImpact !== null"> | ||
| {{ _applicationSubmission.coveFarmImpact }} | ||
| </span> | ||
| <app-no-data [showRequired]="showErrors" *ngIf="!_applicationSubmission.coveFarmImpact"></app-no-data> |
There was a problem hiding this comment.
nitpick: applicationSubmission in covenant, I know that covenant is a type of applicationSubmission but "covenant" instead looks less wordy
There was a problem hiding this comment.
Gonna leave it alone since I think its better to have the proposals all be consistent.
...rc/app/features/applications/application-details/cove-details/cove-details.component.spec.ts
Show resolved
Hide resolved
...s/apps/alcs/src/providers/typeorm/migrations/1698353808690-add_covenant_submission_fields.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.