Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application decision components #1281

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Application decision components #1281

merged 7 commits into from
Jan 11, 2024

Conversation

lstod
Copy link
Contributor

@lstod lstod commented Jan 10, 2024

  • init decision components
  • update soil components
  • date2 exists for soil

mhuseinov
mhuseinov reviewed Jan 10, 2024
View reviewed changes
...rate-oats-data/applications/decisions/app_components/application_decision_components_init.py Outdated
return None


# def _map_nfu_subtype_code(row):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need this commented code?

bin/migrate-oats-data/common/alcs_application_enum.py Outdated
@@ -59,3 +59,22 @@ class AlcsNaruTypeCode(Enum):
Principal_Residence = "PRIN" # Principal Residence More Than 500m²
Additional_Residence = "ARFU" # Additional Residence for Farm Use
Tourism_Accomodation = "TOUR" # Non-Adhering Tourism Accommodation


class OatsToAlcsNfuTypes(Enum):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename to OatsToAlcsNfuTypesEnum to be consistent with the rest of enums

bin/migrate-oats-data/common/alcs_application_enum.py Outdated
UNU = AlcsNfuTypeCode.Unused.value


class OatsLegislationCodes(Enum):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as above

trslater
trslater approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@trslater trslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming @mhuseinov's changes

mhuseinov
mhuseinov approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@mhuseinov mhuseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lstod lstod merged commit 9eec334 into develop Jan 11, 2024
3 checks passed
@lstod lstod deleted the feature/ALCS-1362 branch January 11, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trslater trslater trslater approved these changes

@mhuseinov mhuseinov mhuseinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lstod @trslater @mhuseinov