Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.1 - Fix bugs from internal usethis changes (and others) #46

Merged
merged 16 commits into from
Aug 17, 2018
Merged

Conversation

ateucher
Copy link
Contributor

@ateucher ateucher commented Aug 14, 2018

Closes #45:

  • Replaced usethis:::is_proj with usethis:::possibly_in_proj
  • Rolled our own done_bullet and not_done_bullet.

Partially addresses #39:

  • Since @boshek's PR to usethis was merged and published to CRAN, removed the tryCatch wrapper around usethis::use_template()

Miscellaneous usethis-related changes:

  • Added rmarkdown to Suggests as needed to test create_bcgov_package() (usethis::use_vignette() checks that it's installed)
  • use normalizePath in create_bcgov_package so that usethis::create_package() doesn't choke when path == "."

Miscellanous changes (related to CRAN compliance even though not submitting to CRAN):

  • moved README images to tools/readme directory
  • Used canonical CRAN urls in NEWS and README
  • Changed packge title to Title Case in DESCRIPTION

@boshek boshek merged commit 7c0bce5 into master Aug 17, 2018
@boshek boshek deleted the devel branch August 17, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants