Plot edits #25
Merged
Plot edits #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ateucher
reviewed
Jun 26, 2018
R/gwlAreaPlot.R
Outdated
|
|
||
| vals <- vals[2] | ||
| labs <- labs[2] | ||
| override_list <- lapply(override_list, `[`, 2) |
There was a problem hiding this comment.
Tx! copy-paste-try-bonk-figureoutwhatcodedoes-tweak-worked....
ateucher
reviewed
Jun 26, 2018
R/gwlAreaPlot.R
Outdated
| } else { | ||
| vals <- vals[1] | ||
| labs <- labs[1] | ||
| override_list <- lapply(override_list, `[`, 1) | ||
| } | ||
|
|
||
| if (show_stable_line) { |
There was a problem hiding this comment.
This is great. I think it could be simplified by lumping the logic a bit - does this make sense?
if (show_stable_line || tolower(trend_category) != "stable" {
plot.area <- plot.area +
geom_abline(aes_string(intercept = "intercept", slope = "slope", colour = "'LTT'"),
data = data.frame(intercept = -int.well, slope = slope), size = 1)
} else if (tolower(trend_category) == "stable") {
vals <- vals[2]
labs <- labs[2]
override_list <- lapply(override_list, `[`, 2)
}There was a problem hiding this comment.
Yes, I was sure there was a more efficient path than an embedded if/else. I had not seen the || or the if/else if. Cool.
Co-authored-by: Andy Teucher <andy.teucher@gov.bc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show_stable_lineargument togwl_area_plotwith default not to plot trend line if result is stabletrendtotrend_categorygwl_area_plot(Trend: to Category: with slope only when category not stable, no P-value)@ateucher Not sure that an if/else inside an if/else is kosher?