Funding Sources Feature Branch #1066

NickPhura · 2023-08-03T19:38:25Z

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-171
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-172
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-173
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-174
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-181
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-195

Description of Changes

Manage Funding Sources

Add new Funding Source tables.
Add new pages to create/edit/view/delete funding sources.

Survey

Add new funding source controls on create/edit/view survey pages.

Project

Removed all funding source controls (APP, API, DB) from projects.

Testing Notes

Manage Funding Sources

View list of funding sources
Add/edit/delete funding source
View single funding source with survey references

Survey

Add funding sources to survey
Remove funding sources from survey
Edit funding source amount on survey
View funding sources associated to survey on survey page

Project

No references to Funding should be present

github-actions · 2023-08-03T19:38:36Z

Openshift URLs for the PR Deployment:

codecov · 2023-08-03T19:41:19Z

Codecov Report

Merging #1066 (e6bc251) into dev (2f43099) will decrease coverage by 1.59%.
The diff coverage is 57.71%.

@@            Coverage Diff             @@
##              dev    #1066      +/-   ##
==========================================
- Coverage   67.34%   65.75%   -1.59%     
==========================================
  Files         403      406       +3     
  Lines       12580    12646      +66     
  Branches     2105     2040      -65     
==========================================
- Hits         8472     8316     -156     
- Misses       3557     3812     +255     
+ Partials      551      518      -33

Files Changed	Coverage Δ
api/src/models/project-create.ts	`93.61% <ø> (-1.47%)`	⬇️
api/src/models/project-update.ts	`100.00% <ø> (+7.69%)`	⬆️
api/src/models/project-view.ts	`100.00% <ø> (ø)`
api/src/openapi/schemas/project.ts	`100.00% <ø> (ø)`
api/src/paths/project/{projectId}/survey/create.ts	`96.15% <ø> (ø)`
api/src/paths/project/{projectId}/survey/list.ts	`96.66% <ø> (ø)`
...hs/project/{projectId}/survey/{surveyId}/update.ts	`96.29% <ø> (ø)`
...roject/{projectId}/survey/{surveyId}/update/get.ts	`84.37% <ø> (+1.51%)`	⬆️
...aths/project/{projectId}/survey/{surveyId}/view.ts	`95.83% <ø> (ø)`
api/src/paths/project/{projectId}/update.ts	`91.37% <ø> (-0.15%)`	⬇️
... and 68 more

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

drop old tables, insert data nuke funding

KjartanE

🐈

al-rosenthal

🦋

KjartanE

🐈

* Fixed linting errors * Removed some test skips * ignore-skip * Removed some snapshots * ran fix, removed comment * Updated hook dependencies * Added useMemo for debounce call * add useMemo dependency --------- Co-authored-by: Alfred Rosenthal <alfred.k.rosenthal@gmail.com> Co-authored-by: Nick Phura <nickphura@gmail.com>

al-rosenthal

☺️

KjartanE

🐱

al-rosenthal

🍼

Many were failing due issues related to: https://github.com/styled-components/jest-styled-components Rename 'test' to 'it'

sonarcloud · 2023-08-16T01:44:07Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
1.5% Duplication

al-rosenthal

🧪

KjartanE

:cat

NickPhura added 2 commits August 3, 2023 09:06

WIP

3bcef94

Stub out initial endpoints, service/repo files, and frontend folders

fbffab8

NickPhura and others added 26 commits August 3, 2023 12:48

Initial version of get funding sources endpoint

9ce55d3

Add funding source router and initial list page

7a3cb29

wip

1fc3eb0

wip

bb674b4

stubbing out more ui

a97e916

moved dialog

ba5c372

updating ui

62c1c2e

basic form is submitting

c39d1a5

Update funding api tests

66d32d3

added comment

20fda97

Merge branch 'SIMSBIOHUB-173' into funding_sources_feature

d5dad84

Add funding source api code

6a9b84f

Merge remote-tracking branch 'origin/dev' into funding_sources_feature

3824b21

intial tables setup

8d8e7ac

drop old tables, insert data nuke funding

updated get endpoint with search params

3a05f36

Update funding endpoints

74706b4

Merge branch 'SIMSBIOHUB-174' into funding_sources_feature

a04bcfe

Merge branch 'funding_sources_feature' into SIMSBIOHUB-173

fcc0713

remove project funding frontend, fix basic seed

246461f

Update funding source api and tests

42bd70b

Merge branch 'SIMSBIOHUB-174' into funding_sources_feature

238fd74

applied stash

437d9e6

Merge branch 'funding_sources_feature' into SIMSBIOHUB-173

cbccf17

added work for creating funding source

11063a4

fixed get list

2ecd793

happy path adding funding source is working

4c97382

Fix code smells

2302521

KjartanE previously approved these changes Aug 15, 2023

View reviewed changes

al-rosenthal previously approved these changes Aug 15, 2023

View reviewed changes

Update snapshots

262231b

NickPhura dismissed stale reviews from al-rosenthal and KjartanE via 262231b August 15, 2023 18:27

KjartanE previously approved these changes Aug 15, 2023

View reviewed changes

Fixing content and naming conventions

302880d

jeznorth dismissed KjartanE’s stale review via 302880d August 15, 2023 18:38

curtisupshall and others added 4 commits August 15, 2023 12:10

Merge remote-tracking branch 'origin/dev' into funding_sources_feature

7df5f54

Merge branch 'dev' into funding_sources_feature

35fae19

Fix test

f81e413

jeznorth previously approved these changes Aug 15, 2023

View reviewed changes

al-rosenthal previously approved these changes Aug 15, 2023

View reviewed changes

fixing code smells

2c6bc2b

al-rosenthal dismissed stale reviews from jeznorth and themself via 2c6bc2b August 15, 2023 20:27

KjartanE previously approved these changes Aug 15, 2023

View reviewed changes

al-rosenthal previously approved these changes Aug 15, 2023

View reviewed changes

Skip ALL snapshots.

e6bc251

Many were failing due issues related to: https://github.com/styled-components/jest-styled-components Rename 'test' to 'it'

NickPhura dismissed stale reviews from al-rosenthal and KjartanE via e6bc251 August 16, 2023 01:43

al-rosenthal approved these changes Aug 16, 2023

View reviewed changes

NickPhura requested review from KjartanE and jeznorth August 16, 2023 19:56

KjartanE approved these changes Aug 16, 2023

View reviewed changes

NickPhura merged commit 8232845 into dev Aug 16, 2023
18 of 20 checks passed

NickPhura deleted the funding_sources_feature branch August 16, 2023 20:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Funding Sources Feature Branch #1066

Funding Sources Feature Branch #1066

NickPhura commented Aug 3, 2023 •

edited

Loading

github-actions bot commented Aug 3, 2023

codecov bot commented Aug 3, 2023 •

edited

Loading

KjartanE left a comment

al-rosenthal left a comment

KjartanE left a comment

al-rosenthal left a comment

KjartanE left a comment

al-rosenthal left a comment

sonarcloud bot commented Aug 16, 2023

al-rosenthal left a comment

KjartanE left a comment

Funding Sources Feature Branch #1066

Funding Sources Feature Branch #1066

Conversation

NickPhura commented Aug 3, 2023 • edited Loading

Links to Jira Tickets

Description of Changes

Manage Funding Sources

Survey

Project

Testing Notes

Manage Funding Sources

Survey

Project

github-actions bot commented Aug 3, 2023

codecov bot commented Aug 3, 2023 • edited Loading

Codecov Report

KjartanE left a comment

Choose a reason for hiding this comment

al-rosenthal left a comment

Choose a reason for hiding this comment

KjartanE left a comment

Choose a reason for hiding this comment

al-rosenthal left a comment

Choose a reason for hiding this comment

KjartanE left a comment

Choose a reason for hiding this comment

al-rosenthal left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Aug 16, 2023

al-rosenthal left a comment

Choose a reason for hiding this comment

KjartanE left a comment

Choose a reason for hiding this comment

NickPhura commented Aug 3, 2023 •

edited

Loading

codecov bot commented Aug 3, 2023 •

edited

Loading