Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt - Memory Leak Fix #1172

Merged
merged 18 commits into from
Nov 20, 2023
Merged

Tech Debt - Memory Leak Fix #1172

merged 18 commits into from
Nov 20, 2023

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Nov 16, 2023

Fix for memory heap build issue

  • Removed poorly implemented MUI types
  • Temporarily changed types to any for faster typescript compilation
  • Added Makefile commands for running ts-trace and analyze-trace
  • LoadingButton sx prop appears to be broken / causes ts-trace hotspot issues

Testing

To search for typescript hotspots or duplicate packages run:

make trace-app
make trace-api

Remaining Hotspots

ErrorDialog - tried a few things here, uncertain where the issue is occuring from
MultiAutoCompleteVariableSize - skipping this one

@MacQSL MacQSL added the Do Not Merge PR should not be merged label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (449edb5) 60.82% compared to head (eaa1524) 60.81%.

Files Patch % Lines
app/src/components/dialog/ErrorDialog.tsx 0.00% 1 Missing and 1 partial ⚠️
app/src/contexts/observationsTableContext.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1172      +/-   ##
==========================================
- Coverage   60.82%   60.81%   -0.01%     
==========================================
  Files         564      564              
  Lines       16968    16967       -1     
  Branches     2627     2626       -1     
==========================================
- Hits        10320    10319       -1     
- Misses       5962     5963       +1     
+ Partials      686      685       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MacQSL MacQSL changed the title testing fix for memory leak Memory Leak Fix Nov 17, 2023
@MacQSL MacQSL changed the title Memory Leak Fix Tech Debt - Memory Leak Fix Nov 20, 2023
NickPhura
NickPhura previously approved these changes Nov 20, 2023
curtisupshall
curtisupshall previously approved these changes Nov 20, 2023
@jeznorth jeznorth removed the Do Not Merge PR should not be merged label Nov 20, 2023
@MacQSL MacQSL dismissed stale reviews from curtisupshall and NickPhura via 745794f November 20, 2023 19:53
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MacQSL MacQSL merged commit 3f6531d into dev Nov 20, 2023
18 of 20 checks passed
@MacQSL MacQSL deleted the SIMSBIOHUB-Memory-Leak branch November 20, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants