Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-333: Telemetry Table #1177

Merged
merged 106 commits into from
Dec 12, 2023
Merged

SIMSBIOHUB-333: Telemetry Table #1177

merged 106 commits into from
Dec 12, 2023

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Nov 29, 2023 •
edited by al-rosenthal
Loading

Links to Jira Tickets

SIMSBIOHUB-333

Description of Changes

Copied the observations architecture and workflow for managing telemetry and deployments for critters.

Notes

The file uploading will now be finished in SIMSBIOHUB-403 because of the complexity in handling uploaded data

Testing Notes

  • Navigate to a survey
  • Click 'Manage Animals' and add an animal
  • Navigate back to survey page and click 'Manage Telemetry'
  • Click 'Add Deployment' and fill out the form
  • Click 'Add Record' and fill out table row

al-rosenthal and others added 30 commits November 14, 2023 12:23
@al-rosenthal
got basic UI section and router wired up
2d29f9f
@al-rosenthal
routed to new page
6bc2c1a
@al-rosenthal
basic list component created
155deee
@al-rosenthal
built basic list layout
84e7a19
@al-rosenthal
added deployment to survey context, wired up list with deployment api
d37a3e7
@al-rosenthal
wired up list
bf5e59f
@al-rosenthal
added skeleton loader component
86166f9
@al-rosenthal
clean up
a649b53
@al-rosenthal
Merge branch 'dev' into SIMSBIOHUB-333
df9688e
@al-rosenthal
updated api for list
08cd378
@al-rosenthal
added telemetry form to list
4576dce
@al-rosenthal
dialog properly showing
d93a659
@al-rosenthal
added selector, form is submitting
99fc1dc
@al-rosenthal
updated API, added menu button, added critter selector
549d47c
@al-rosenthal
clean up
c8f736b
@al-rosenthal
added formik validation and stubbing out more work flow changes
69a8b75
@al-rosenthal
stubbing in menu actions
33adcfa
@al-rosenthal
Merge branch 'dev' into SIMSBIOHUB-333
fe9fa60
@al-rosenthal
got add deployment working
b553c6f
@al-rosenthal
refactored form
09b5985
@al-rosenthal
updated validation ui
fceafba
@al-rosenthal
clean up and nw typing
a84653d
@MacQSL
delete / create / get proxy endpoints for BCTW manual telemetry created
dc78928
@MacQSL
Merge branch 'SIMSBIOHUB-333' of https://github.com/bcgov/biohubbc in…
f2c0317 
…to SIMSBIOHUB-333
@al-rosenthal
added edit flow
4122eaa
@al-rosenthal
stubbed out more edit code
e558b97
@MacQSL
updated create structure
4868f58
@MacQSL
Merge branch 'SIMSBIOHUB-333' of https://github.com/bcgov/biohubbc in…
832d375 
…to SIMSBIOHUB-333
@al-rosenthal
stubbing out more edit changes
c01736a
@al-rosenthal
Merge branch 'SIMSBIOHUB-333' of https://github.com/bcgov/biohubbc in…
a0b765e 
…to SIMSBIOHUB-333
curtisupshall
curtisupshall commented Dec 7, 2023
View reviewed changes
Copy link
Contributor Author

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it works well! Just have a handful of minor code comments

app/src/features/surveys/telemetry/ManualTelemetryList.tsx Show resolved Hide resolved
app/src/features/surveys/view/survey-animals/SurveyAnimalsPage.tsx Outdated Show resolved Hide resolved
@al-rosenthal al-rosenthal self-requested a review December 8, 2023 19:55
al-rosenthal
al-rosenthal previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

KjartanE
KjartanE previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@al-rosenthal al-rosenthal dismissed stale reviews from KjartanE and themself via 764935e December 12, 2023 18:06
al-rosenthal
al-rosenthal previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

12.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

al-rosenthal
al-rosenthal approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞

@al-rosenthal al-rosenthal merged commit 8c66d58 into dev Dec 12, 2023
16 of 19 checks passed
@al-rosenthal al-rosenthal deleted the SIMSBIOHUB-333 branch December 12, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickPhura NickPhura NickPhura approved these changes

@al-rosenthal al-rosenthal al-rosenthal approved these changes

@jeznorth jeznorth Awaiting requested review from jeznorth

@MacQSL MacQSL Awaiting requested review from MacQSL

@KjartanE KjartanE Awaiting requested review from KjartanE

Assignees

@al-rosenthal al-rosenthal

@curtisupshall curtisupshall

@KjartanE KjartanE

Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@curtisupshall @NickPhura @al-rosenthal @KjartanE @MacQSL