Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-396: Added aliases to column validator #1178

Merged
merged 9 commits into from
Dec 19, 2023
Merged

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Dec 6, 2023

Links to Jira Tickets

Description of Changes

  • Updates the Observations import pipeline to support alternative spellings and cases for observation latitude and longitude columns:
    • Lat and Latitude should both be recognized as Latitude.
    • Lon, Long, Lng, and Longitude should both be recognized as Longitude
    • Upper and lowercase should both work (case insensitive)

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (99c7762) 58.17% compared to head (212dd81) 58.16%.

Files Patch % Lines
api/src/utils/xlsx-utils/worksheet-utils.ts 66.66% 6 Missing and 2 partials ⚠️
api/src/services/observation-service.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1178      +/-   ##
==========================================
- Coverage   58.17%   58.16%   -0.02%     
==========================================
  Files         590      590              
  Lines       17952    17964      +12     
  Branches     2763     2767       +4     
==========================================
+ Hits        10444    10448       +4     
- Misses       6825     6831       +6     
- Partials      683      685       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall marked this pull request as ready for review December 7, 2023 00:16
@curtisupshall curtisupshall added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Dec 7, 2023
@curtisupshall curtisupshall added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Dec 15, 2023
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this locally, changing the lat/ long columns and everything worked. 🏖️

@curtisupshall curtisupshall merged commit e8fd46a into dev Dec 19, 2023
17 of 19 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-396 branch December 19, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants