Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-488: Paginate survey and sample site list endpoints #1214

Merged
merged 48 commits into from
Feb 23, 2024
Merged

SIMSBIOHUB-488: Paginate survey and sample site list endpoints #1214

merged 48 commits into from
Feb 23, 2024

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Feb 16, 2024 •
edited
Loading

Overview

Links to Jira Tickets

Description of Changes

  • Modifies the survey list endpoint to support server-side pagination
  • Updates the survey list page to use MUI DataGrid
  • Modifies the sample site list endpoint to support server-side pagination
  • Removes some code associated with project/survey submission status
  • Refactors code associated with sampling site, method and period.

Testing Notes

You should be able to:

  • Create several seed projects and seed surveys using the two new environment variables, NUM_SEED_PROJECTS and NUM_SEED_SURVEYS_PER_PROJECT.
  • List surveys at varying page sizes
  • Sort the surveys list by name

@curtisupshall
SIMSBIOHUB-483: Added new env vars for number of seed projects and su…
db4416a 
…rveys
@curtisupshall
SIMSBIOHUB-483: Removed code associated with project drafts. WIP.
696eab1
@curtisupshall
SIMSBIOHUB-483: Removed code associated with project submitted status…
24babdb 
… and project supplementary data.
@curtisupshall
SIMSBIOHUB-483: Removed code associated with project drafts from the …
e4d24b2 
…Create Project page
@curtisupshall
SIMSBIOHUB-483: Renamed start and end date columns for project lists …
b1f4f4a 
…table
@curtisupshall
SIMSBIOHUB-483: Support project list server-side pagination (using co…
acdf5e4 
…mmon pagination API schema)
@curtisupshall
SIMSBIOHUB-483: Restructure projects list endpoint response schema an…
dd83e58 
…d typing to accomodate pagination
@curtisupshall
SIMSBIOHUB-483: Render table counts using Number.toLocaleString
64172ca
@curtisupshall
SIMSBIOHUB-483: Working frontend pagination
adf7e1c
@curtisupshall
SIMSBIOHUB-483: Completed implementation of getProjectCount
df17196
@curtisupshall
SIMSBIOHUB-483: Lint and format fixes
3083888
@curtisupshall
SIMSBIOHUB-483: Support for column sorting
b4c45b8
@curtisupshall
SIMSBIOHUB-483: Fix API tests
f6b8c75
@curtisupshall
SIMSBIOHUB-483: Test coverage and added comments
5aea87e
@curtisupshall
SIMSBIOHUB-483: Minor tweaks to comments
07cc92d
@curtisupshall
SIMSBIOHUB-483: Lint/format fixes
54855b7
@curtisupshall
SIMSBIOHUB-888: Initial commit
681021d
@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@curtisupshall curtisupshall changed the title SIMSBIOHUB-888: Paginate survey and sample site list endpoints SIMSBIOHUB-488: Paginate survey and sample site list endpoints Feb 16, 2024
@curtisupshall curtisupshall added the Not Ready For Review Addressing feedback and/or refactoring label Feb 16, 2024
al-rosenthal

This comment was marked as resolved.

Sign in to view

curtisupshall and others added 2 commits February 22, 2024 13:04
@curtisupshall
SIMSBIOHUB-488: Amended pagination query param schema
80260e7
@NickPhura
Cleanup sample site/method/period type definitions.
728e04e 
Cleanup sample location queries.
Add missing sample site/method/period details to openapi spec.
Misc cleanup
NickPhura
NickPhura previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📄

al-rosenthal

This comment was marked as resolved.

Sign in to view

@NickPhura

This comment was marked as resolved.

Sign in to view
al-rosenthal
al-rosenthal previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran it locally and things look good! 🍨

al-rosenthal
al-rosenthal previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📓

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

al-rosenthal
al-rosenthal approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐩

@curtisupshall curtisupshall merged commit 8bbccc9 into dev Feb 23, 2024
19 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-488 branch February 23, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickPhura NickPhura NickPhura approved these changes

@al-rosenthal al-rosenthal al-rosenthal approved these changes

@MacQSL MacQSL Awaiting requested review from MacQSL

@KjartanE KjartanE Awaiting requested review from KjartanE

Assignees
No one assigned
Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curtisupshall @NickPhura @al-rosenthal @KjartanE