BHBC-2094: Cannot Edit Project Metadata

[KjartanE]

Overview

Links to Jira tickets

• https://quartech.atlassian.net/browse/BHBC-2094

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-893-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-893-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=893

[codecov]

Codecov Report

Merging #893 (b0b7c5b) into dev (d03ff1d) will increase coverage by 0.14%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##              dev     #893      +/-   ##
==========================================
+ Coverage   61.20%   61.34%   +0.14%     
==========================================
  Files         379      380       +1     
  Lines       12250    12274      +24     
  Branches     2185     2191       +6     
==========================================
+ Hits         7498     7530      +32     
+ Misses       4352     4344       -8     
  Partials      400      400              

Impacted Files	Coverage Δ
api/src/queries/survey/survey-delete-queries.ts	100.00% <ø> (+29.16%)	⬆️
api/src/queries/survey/survey-view-queries.ts	100.00% <ø> (ø)
api/src/services/project-service.ts	30.46% <4.76%> (+0.30%)	⬆️
api/src/repositories/project-repository.ts	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AlfredRosenthal]

🐱

found an issue

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[AlfredRosenthal]

🚗