Release to Test

[NickPhura]

Overview

Links to Jira tickets

• {List all applicable Jira tickets}

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-946-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-946-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=946

[codecov]

Codecov Report

Merging #946 (1f15975) into test (f37b559) will decrease coverage by 0.01%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##             test     #946      +/-   ##
==========================================
- Coverage   65.78%   65.77%   -0.01%     
==========================================
  Files         350      350              
  Lines       11308    11305       -3     
  Branches     1959     1960       +1     
==========================================
- Hits         7439     7436       -3     
  Misses       3471     3471              
  Partials      398      398              

Impacted Files	Coverage Δ
api/src/paths/project/{projectId}/update.ts	90.62% <ø> (ø)
app/src/features/projects/edit/EditProjectPage.tsx	0.00% <0.00%> (ø)
app/src/features/projects/view/ProjectPage.tsx	3.57% <ø> (ø)
app/src/components/surveys/SurveysList.tsx	90.90% <50.00%> (-9.10%)	⬇️
app/src/components/fields/ReadMoreField.tsx	100.00% <100.00%> (ø)
...src/features/projects/create/CreateProjectPage.tsx	81.44% <100.00%> (+0.39%)	⬆️
...res/projects/view/components/ProjectObjectives.tsx	100.00% <100.00%> (ø)
app/src/features/surveys/list/SurveysListPage.tsx	88.88% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.5% Duplication