Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2151: Enhance EML call to BioHub EML Submission API when Project or Survey Metadata Updated #954

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

KjartanE
Copy link
Contributor

Overview

Links to Jira tickets

Description of relevant changes

  • {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #954 (c55fb5c) into dev (34b601b) will increase coverage by 14.27%.
The diff coverage is 78.26%.

@@             Coverage Diff             @@
##              dev     #954       +/-   ##
===========================================
+ Coverage   65.77%   80.04%   +14.27%     
===========================================
  Files         350      174      -176     
  Lines       11305     6751     -4554     
  Branches     1960     1211      -749     
===========================================
- Hits         7436     5404     -2032     
+ Misses       3471     1081     -2390     
+ Partials      398      266      -132     
Impacted Files Coverage Δ
api/src/paths/project/create.ts 96.00% <ø> (+2.66%) ⬆️
api/src/paths/project/{projectId}/survey/create.ts 96.15% <ø> (+2.60%) ⬆️
...hs/project/{projectId}/survey/{surveyId}/update.ts 96.15% <ø> (+2.40%) ⬆️
api/src/paths/project/{projectId}/update.ts 91.52% <ø> (+0.90%) ⬆️
api/src/services/project-service.ts 20.93% <50.00%> (+0.69%) ⬆️
api/src/services/survey-service.ts 82.01% <80.00%> (-0.08%) ⬇️
api/src/services/platform-service.ts 96.61% <84.61%> (-3.39%) ⬇️
api/src/models/survey-view.ts 100.00% <100.00%> (ø)
app/src/features/surveys/SurveyPermitForm.tsx
app/src/hooks/useBioHubApi.ts
... and 174 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐩

@AlfredRosenthal AlfredRosenthal merged commit bc59b7c into dev Feb 17, 2023
@AlfredRosenthal AlfredRosenthal deleted the BHBC-2151 branch February 17, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants