Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

Update to data.gov #42

Closed
Mbrownshoes opened this issue May 15, 2017 · 9 comments
Closed

Update to data.gov #42

Mbrownshoes opened this issue May 15, 2017 · 9 comments
Assignees

Comments

@Mbrownshoes
Copy link

Mbrownshoes commented May 15, 2017

There aa few more small changes needed, some of which (unfortunately) conflict with the last changes made.

  • Add DataBC back to the title, just to the right of the bc gov logo, as it is with the current prod deployment but without the vertical yellow line next to the bc gov logo)
  • return the ribbon, as in the current site:
    screen shot 2017-05-15 at 9 24 25 am
    but have the ribbon items move to the hamburger as soon as the user scrolls down -as done on this pages: http://engage.gov.bc.ca/govtogetherbc/
  • add 'Dataset Usage' to the ribbon to the right of 'Contact Us'. The hyperlink should go here: https://catalogue.data.gov.bc.ca/data/site-usage/dataset
    -Remove “Site Usage” from the hamburger menu and ribbon.
    -remove the magnifying glass from the header until the user scrolls down.
    screen shot 2017-05-15 at 9 37 58 am
  • implement Add predictive search to search bar #40
    It should appear at the same time the ribbon items move to the hamburger.

@ll911

@h3devin
Copy link
Contributor

h3devin commented May 15, 2017

but have the ribbon items move to the hamburger as soon as the user scrolls down -as done on this pages: http://engage.gov.bc.ca/govtogetherbc/

Did you also want to hide the hamburger menu (until the user scrolls down) like those pages do as well?

@ll911
Copy link
Contributor

ll911 commented May 15, 2017 via email

@h3devin
Copy link
Contributor

h3devin commented May 17, 2017

Similar to http://engage.gov.bc.ca/govtogetherbc/, did we want to show a search bar in place of the search/menu buttons until the user scrolls down?

@ll911
Copy link
Contributor

ll911 commented May 17, 2017 via email

@Mbrownshoes
Copy link
Author

@h3devin I agree with @ll911 we want the magnifying glass hidden until scrolling down

h3devin added a commit to HighwayThree/data-fp that referenced this issue May 17, 2017
kfishwick added a commit that referenced this issue May 17, 2017
Theme revisions from #42, autocomplete
@h3devin
Copy link
Contributor

h3devin commented May 18, 2017

I've applied the changes in my latest PR.

I went with the Data Catalogue's implementation for autocomplete. It should be more or less the same.

@ll911
Copy link
Contributor

ll911 commented May 18, 2017 via email

@kfishwick kfishwick assigned Mbrownshoes and unassigned h3devin May 18, 2017
h3devin added a commit to HighwayThree/data-fp that referenced this issue May 19, 2017
kfishwick added a commit that referenced this issue May 19, 2017
#44: Cleaning up style from #42 updates
@Mbrownshoes
Copy link
Author

@h3devin can we get the DataBC font to align better with the bc gov logo, similar to http://engage.gov.bc.ca/govtogetherbc/. It's a bit offset now.

@h3devin
Copy link
Contributor

h3devin commented May 29, 2017

I updated the text alignment as part of #45.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants