EHPR-117 | Slack Alerting #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arranfw
force-pushed
the
EHPR-117-Alerting
branch
from
3ba5a96
to
96bb11d
Compare
fwpushan
suggested changes
Jan 7, 2022
dbayly-freshworks
approved these changes
Jan 7, 2022
added 2 commits
January 7, 2022 11:23
added 16 commits
January 7, 2022 11:23
arranfw
force-pushed
the
EHPR-117-Alerting
branch
from
3e06374
to
c054ec2
Compare
added 7 commits
January 7, 2022 11:26
fwpushan
reviewed
Jan 7, 2022
| message = { | ||
| url: config.url, | ||
| method: config.method, | ||
| ...(response?.data ? { data: response.data } : {}), |
There was a problem hiding this comment.
what if data contains any sensitive info or PI?
There was a problem hiding this comment.
This response would be what the external API is returning as error data so it shouldn't have PII
In this implementation the logger isn't responsible for filtering
We've added a bit of filtering in the error filter to prevent logging of the submission payload
We should also be diligent in not explicitly logging PII through info/warn methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
![image](https://user-images.githubusercontent.com/71518072/148295052-744a024e-a8ac-4e91-bf4a-76cffe92bfcb.png