EHPR-186 | Integration tests #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arranfw
force-pushed
the
EHPR-186-Integration-Tests
branch
6 times, most recently
from
73e3d00
to
d33f227
Compare
fwpushan
reviewed
Jan 11, 2022
arranfw
force-pushed
the
EHPR-186-Integration-Tests
branch
7 times, most recently
from
da32d60
to
75c350c
Compare
arranfw
force-pushed
the
EHPR-186-Integration-Tests
branch
from
72636b7
to
79d6aab
Compare
| @echo "++\n*****" | ||
|
|
||
| start-test-db: | ||
| NODE_ENV=test docker-compose -f docker-compose.test.yaml up --build -d |
There was a problem hiding this comment.
Feels a bit weird to have a separate db docker container for testing.
We should be able to reuse the same connection for the main app.
There was a problem hiding this comment.
I wanted to make it a completely separate database so it could be configured slightly differently and so it wouldn't interfere with the main app if it's already running, what do you think?
There was a problem hiding this comment.
Normally we wiped-out (tear down) db for correctness of test and isolation of test execution. In that case using separate database is good choice.
added 13 commits
January 12, 2022 13:51
arranfw
force-pushed
the
EHPR-186-Integration-Tests
branch
from
79d6aab
to
236f783
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make api-integration-testto run integration tests with a transient postgres container