Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EHPR-202 | Export Script + Merge Scripts Package #144

Merged
merged 16 commits into from
Jan 12, 2022
Merged

EHPR-202 | Export Script + Merge Scripts Package #144

merged 16 commits into from
Jan 12, 2022

Conversation

arranfw
Copy link
Contributor

@arranfw arranfw commented Jan 12, 2022

@arranfw arranfw changed the title EHPR-202 |Export Script + Merge Scripts Package EHPR-202 | Export Script + Merge Scripts Package Jan 12, 2022
fwpushan
fwpushan reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@fwpushan fwpushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me but I saw some scripts/out element. Can you check and make sure they are not ignored.

dbayly-freshworks
dbayly-freshworks approved these changes Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@dbayly-freshworks dbayly-freshworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit hard to judge, but I think the risks for this script is low. If these csv extracts do end up having issues we can tweak the script as we use it.

I have a few nits, but overall I think this is good.

packages/scripts/data/locations.csv Outdated Show resolved Hide resolved
packages/scripts/README.md Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arranfw
Copy link
Contributor Author

arranfw commented Jan 12, 2022

Fixed the in/out folders, the intent was to keep the folders but ignore the children

dbayly-freshworks
dbayly-freshworks approved these changes Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@dbayly-freshworks dbayly-freshworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@arranfw arranfw merged commit 99d7ebd into main Jan 12, 2022
@arranfw arranfw deleted the EHPR-Stream_script branch January 12, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwpushan fwpushan fwpushan approved these changes

@dbayly-freshworks dbayly-freshworks dbayly-freshworks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arranfw @fwpushan @dbayly-freshworks