Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EHPR-205 Added previous deployment question #147

Merged
merged 4 commits into from
Jan 13, 2022
Merged

EHPR-205 Added previous deployment question #147

merged 4 commits into from
Jan 13, 2022

Conversation

dbayly-freshworks
Copy link
Collaborator

Screen Shot 2022-01-12 at 3 46 10 PM

@dbayly-freshworks dbayly-freshworks changed the title Added previous deployment question EHPR-205 Added previous deployment question Jan 12, 2022
@dbayly-freshworks dbayly-freshworks force-pushed the EHPR-205_Previous_deployment_question branch from 43fdac6 to 6187346 Compare January 13, 2022 00:01
arranfw
arranfw reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@arranfw arranfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit to fix the error not showing up when submitting the page without answering the question, I left a small question but otherwise this looks good

apps/api/test/fixture/validSubmission.json
@@ -42,7 +42,8 @@
],
"placementOptions": ["other", "anywhere"],
"hasImmunizationTraining": true,
"deploymentDuration": "twoToFour"
"deploymentDuration": "twoToFour",
"hasPreviousDeployment": "yes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add this to the invalidSubmission fixture as well to keep it as the single error for firstName?

@dbayly-freshworks dbayly-freshworks force-pushed the EHPR-205_Previous_deployment_question branch from 99d0a2e to 68e0d35 Compare January 13, 2022 19:16
@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dbayly-freshworks dbayly-freshworks merged commit 12971d5 into main Jan 13, 2022
@dbayly-freshworks dbayly-freshworks deleted the EHPR-205_Previous_deployment_question branch January 13, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arranfw arranfw arranfw approved these changes

@fwpushan fwpushan Awaiting requested review from fwpushan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbayly-freshworks @arranfw