Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version endpoint to give actual env name #149

Merged
merged 1 commit into from
Jan 13, 2022
Merged

update version endpoint to give actual env name #149

merged 1 commit into from
Jan 13, 2022

Conversation

arranfw
Copy link
Contributor

@arranfw arranfw commented Jan 13, 2022

NODE_ENV will always be production so let's use ENV_NAME which is probably the originally intended variable to expose here

@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dbayly-freshworks dbayly-freshworks merged commit a127779 into main Jan 13, 2022
@dbayly-freshworks dbayly-freshworks deleted the update-version-endpoint branch January 13, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbayly-freshworks dbayly-freshworks dbayly-freshworks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arranfw @dbayly-freshworks