Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EHPR-159 EHPR-160 consistent dropdown list styles #166

Merged
merged 5 commits into from
Mar 21, 2022
Merged

EHPR-159 EHPR-160 consistent dropdown list styles #166

merged 5 commits into from
Mar 21, 2022

Conversation

sunghwan-park-fw
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Runs Passes ✔ Errors ❌
6 5 1

  1. ❌ http://localhost:3000/submission/3

    WCAG Code: color-contrast

    Context: <div class=" css-qc6sy-singleValue">Family Physician/General Practi...</div>

    Selector: #__next > div > main > div > div > div > form > div > div:nth-child(1) > div > div:nth-child(3) > fieldset > div > div:nth-child(1) > div > div:nth-child(2) > div > div:nth-child(1) > div:nth-child(1)

    Elements must have sufficient color contrast (https://dequeuniversity.com/rules/axe/4.3/color-contrast?application=axeAPI)

3 similar comments
@github-actions
Copy link

Runs Passes ✔ Errors ❌
6 5 1

  1. ❌ http://localhost:3000/submission/3

    WCAG Code: color-contrast

    Context: <div class=" css-qc6sy-singleValue">Family Physician/General Practi...</div>

    Selector: #__next > div > main > div > div > div > form > div > div:nth-child(1) > div > div:nth-child(3) > fieldset > div > div:nth-child(1) > div > div:nth-child(2) > div > div:nth-child(1) > div:nth-child(1)

    Elements must have sufficient color contrast (https://dequeuniversity.com/rules/axe/4.3/color-contrast?application=axeAPI)

@github-actions
Copy link

Runs Passes ✔ Errors ❌
6 5 1

  1. ❌ http://localhost:3000/submission/3

    WCAG Code: color-contrast

    Context: <div class=" css-qc6sy-singleValue">Family Physician/General Practi...</div>

    Selector: #__next > div > main > div > div > div > form > div > div:nth-child(1) > div > div:nth-child(3) > fieldset > div > div:nth-child(1) > div > div:nth-child(2) > div > div:nth-child(1) > div:nth-child(1)

    Elements must have sufficient color contrast (https://dequeuniversity.com/rules/axe/4.3/color-contrast?application=axeAPI)

@github-actions
Copy link

Runs Passes ✔ Errors ❌
6 5 1

  1. ❌ http://localhost:3000/submission/3

    WCAG Code: color-contrast

    Context: <div class=" css-qc6sy-singleValue">Family Physician/General Practi...</div>

    Selector: #__next > div > main > div > div > div > form > div > div:nth-child(1) > div > div:nth-child(3) > fieldset > div > div:nth-child(1) > div > div:nth-child(2) > div > div:nth-child(1) > div:nth-child(1)

    Elements must have sufficient color contrast (https://dequeuniversity.com/rules/axe/4.3/color-contrast?application=axeAPI)

@github-actions
Copy link

Runs Passes ✔ Errors ❌
6 5 1

  1. ❌ http://localhost:3000/submission/3

    WCAG Code: color-contrast

    Context: <div class=" css-qc6sy-singleValue">Family Physician/General Practi...</div>

    Selector: #__next > div > main > div > div > div > form > div > div:nth-child(1) > div > div:nth-child(3) > fieldset > div > div:nth-child(1) > div > div:nth-child(2) > div > div:nth-child(1) > div:nth-child(1)

    Elements must have sufficient color contrast (https://dequeuniversity.com/rules/axe/4.3/color-contrast?application=axeAPI)

1 similar comment
@github-actions
Copy link

Runs Passes ✔ Errors ❌
6 5 1

  1. ❌ http://localhost:3000/submission/3

    WCAG Code: color-contrast

    Context: <div class=" css-qc6sy-singleValue">Family Physician/General Practi...</div>

    Selector: #__next > div > main > div > div > div > form > div > div:nth-child(1) > div > div:nth-child(3) > fieldset > div > div:nth-child(1) > div > div:nth-child(2) > div > div:nth-child(1) > div:nth-child(1)

    Elements must have sufficient color contrast (https://dequeuniversity.com/rules/axe/4.3/color-contrast?application=axeAPI)

@sunghwan-park-fw sunghwan-park-fw marked this pull request as draft March 17, 2022 16:33
@sunghwan-park-fw sunghwan-park-fw marked this pull request as ready for review March 17, 2022 22:12
@sunghwan-park-fw sunghwan-park-fw changed the title Consistent dropdown list styles EHPR-159 EHPR-160 Consistent dropdown list styles Mar 17, 2022
@sunghwan-park-fw sunghwan-park-fw changed the title EHPR-159 EHPR-160 Consistent dropdown list styles EHPR-159 EHPR-160 consistent dropdown list styles Mar 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dbayly-freshworks
dbayly-freshworks approved these changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@dbayly-freshworks dbayly-freshworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@sunghwan-park-fw sunghwan-park-fw merged commit f0fd7d9 into main Mar 21, 2022
@sunghwan-park-fw sunghwan-park-fw deleted the ehpr-160_dropdown-styling branch March 21, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbayly-freshworks dbayly-freshworks dbayly-freshworks approved these changes

@vyasworks vyasworks Awaiting requested review from vyasworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunghwan-park-fw @dbayly-freshworks @arranfw