V1.0.7 #11
V1.0.7 #11
Conversation
| const double maxGFL = 1.0; | ||
| const double defaultGFL = 0.35; | ||
| const double minGS = 0; | ||
| const double maxGS = 60; |
There was a problem hiding this comment.
comments to explain what GFL and GS stand for would be helpful :)
There was a problem hiding this comment.
Refer to GLC-X-10 Appendix I (https://cfs.nrcan.gc.ca/publications/download-pdf/31414):
GFL Grass Fuel Load
GS Ground Slope
| @@ -176,12 +150,6 @@ class HomePageState extends State<HomePage> { | |||
| // onTap: () { | |||
| // _changeSection(Section.fwi); | |||
| // }), | |||
There was a problem hiding this comment.
reminder just in case - do you still need this commented-out code?
There was a problem hiding this comment.
Indeed. Next big feature that's been requested is FWI.
| @@ -52,7 +50,9 @@ BasicSettings _loadBasic(SharedPreferences prefs) { | |||
| altitude: prefs.getDouble('altitude') ?? defaultAltitude)); | |||
|
|
|||
| basicInput.waz = prefs.getDouble('waz') ?? 0; | |||
There was a problem hiding this comment.
wtf does "waz" stand for?
There was a problem hiding this comment.
Refer to ST-X-3 Appendix II; wind azimuth in degrees; (https://cfs.nrcan.gc.ca/publications/download-pdf/10068)
This trips up @conbrad as well all the time. I've opted to stick to the conventions used in the wildfire papers, and in the CFFDRS R package. Using descriptive variable names ends up being more confusing, because it's hard to trace back the math.
Summary:
BUI no longer changing when fuel type changes. PDF slider no longer showing for M1/M2. 2 decimal places for fuel consumption. Slope limited to 60%. GFL changed to slider (resolves various bugs relating to text input), and no longer storing user value.
Detail: