Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds self-verify functionality #348

Merged
merged 9 commits into from
Oct 7, 2019
Merged

Conversation

nrempel
Copy link
Contributor

@nrempel nrempel commented Sep 17, 2019

No description provided.

Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
…technique

Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
@nrempel nrempel marked this pull request as ready for review September 17, 2019 22:41
@nrempel nrempel requested review from esune and ianco September 17, 2019 22:41
Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
@nrempel
Copy link
Contributor Author

nrempel commented Sep 17, 2019

This depends on this feature: openwallet-foundation/acapy#181

Once that is merge, we will need to cut a new release of aca-py and update this repo to build from the new release

@esune
Copy link
Member

esune commented Sep 23, 2019

This depends on this feature: hyperledger/aries-cloudagent-python#181

Once that is merge, we will need to cut a new release of aca-py and update this repo to build from the new release

@andrewwhitehead please let me know when aca-py 0.3.3 is out, and I will release a new version of aries-cloudagent-container so that we can re-build and test these changes.

Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
@WadeBarnes
Copy link
Member

@esune, Please confirm whether or not your requests have been addressed.

Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrempel, According to @esune it appears we need to update the tob-agent to bcgovimages/aries-cloudagent:py36-1.11-1_0.3.3; https://github.com/bcgov/indy-catalyst/blob/master/docker/tob-agent/Dockerfile

Please confirm.

Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
@nrempel
Copy link
Contributor Author

nrempel commented Oct 4, 2019

Caught me while I was on lunch! The latest commit updates the image.

@nrempel
Copy link
Contributor Author

nrempel commented Oct 4, 2019

I've tested this locally and everything works.

We are still "faking" the verified response because of the bug in libindy. Once this change has been merged and released, we can update to remove the workaround:
hyperledger-archives/indy-sdk#1893

@esune
Copy link
Member

esune commented Oct 7, 2019

Looks good to me. I see we also already have an issue logged to track this ( #349 ). 👍

@esune
Copy link
Member

esune commented Oct 7, 2019

@WadeBarnes this is ready to go once your request for changes is dismissed.

@WadeBarnes WadeBarnes merged commit c4c5f23 into bcgov:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants