Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indy_vdr specified version because it occurs when installing as pip3… #51

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

mingi3442
Copy link
Contributor

An error occurs while installing indy_vdr when running a demo.
Verified normal operation if the version is specified.
This request specifies the version of indy_vdr

@swcurran
Copy link
Contributor

Thanks for the PR!

@usingtechnology @andrewwhitehead — I assume this is needed for now. We’ll have to update this again when the final Indy VDR 0.4.0 goes out, right? Any other options?

Thanks

@usingtechnology
Copy link

right now, indy-vdr is at dev16, so gets out of date quickly. not sure if we want indy-vdr to be published with latest. That still won't help when 0.4.0 is final and published. We will have to return to this and update requirements to the final 0.4.0 version.

@swcurran
Copy link
Contributor

OK — so let’s go ahead and merge this, and then we’ll track the need to update it when indy-vdr is updated.

requirements.txt Outdated
# indy_vdr
# Error loading library: indy_vdr specified version because it occurs when installing as pip3 install indy-vdr.
indy_vdr==0.4.0.dev1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to “0.4.0.dev16” and confirm it is still working. Sorry I missed that dev1 was not the latest.

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After modifying to dev16, it was confirmed that it also works normally when running.
And then I commit again

@mingi3442 mingi3442 force-pushed the main branch 3 times, most recently from ac0ef26 to b34c505 Compare June 27, 2023 03:23
Signed-off-by: Lee MinGi <mingi3442@gmail.com>
Signed-off-by: Lee MinGi <mingi3442@gmail.com>
Signed-off-by: Lee MinGi <mingi3442@gmail.com>
@swcurran swcurran merged commit 3d1d845 into bcgov:main Jun 27, 2023
@swcurran
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants