feat: add endpoints for putting and getting tails files by hash #53
Conversation
Signed-off-by: Char Howland <char@indicio.tech>
Signed-off-by: Char Howland <char@indicio.tech>
Signed-off-by: Char Howland <char@indicio.tech>
Signed-off-by: Char Howland <char@indicio.tech>
Signed-off-by: Char Howland <char@indicio.tech>
| # Tails file must start with "00 02" | ||
| tmp_file.seek(0) | ||
| if tmp_file.read(2) != b'\x00\x02': | ||
| raise web.HTTPBadRequest(text='Tails file must start with "00 02".') |
There was a problem hiding this comment.
Perhaps it would be better to not be so specific about what went wrong?
| @@ -46,7 +46,7 @@ exportEnvironment() { | |||
| export GENESIS_URL=${GENESIS_URL:-http://$DOCKERHOST:9000/genesis} | |||
| export STORAGE_PATH=${STORAGE_PATH:-/tmp/tails-files} | |||
| export LOG_LEVEL=${LOG_LEVEL:-INFO} | |||
| export TAILS_SERVER_URL=${TAILS_SERVER_URL:-http://$DOCKERHOST:6543} | |||
| export TAILS_SERVER_URL=${TAILS_SERVER_URL:-http://host.docker.internal:6543} | |||
There was a problem hiding this comment.
We can probably not include this change.
There was a problem hiding this comment.
This change may not work on Linux. I'm not sure if the Linux version of Docker has caught up with the Windows and Mac version that use host.docker.internal automatically. The script was originally setup to autodetect the docker host URL or IP based on the platform. Refer to the script at the top of the file.
indy-tails-server/docker/manage
Lines 15 to 17 in c358d5a
If the Linux version of Docker has caught up and is host.docker.internal aware, you can ignore this comment.
There was a problem hiding this comment.
Looking through the docker release notes, it appears using host.docker.internal still requires some manual steps to work on Linux; it's not automatic like on Mac and Windows.
There was a problem hiding this comment.
I’ve reverted this change in the next PR as I hit this problem in testing.
|
Happy to merge as is. Anything bad likely to happen with the docker.host change? I’m not good at PRs to PRs, so we can address after. |
This PR adds endpoints for putting and getting tails files by hash. This change is to support using this project with ledgers other than just Indy where the revocation registry ID might not be URL friendly and so the tails server doesn't have to know how to resolve objects from any arbitrary ledger.
The
PUT /hash/{tails-hash}endpoint will validate the hash against the uploaded file and will also ensure the tails file "looks" like a tails file. Details of the checks can be found in the comments on the code.