Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21442 Legal API - Add filter to configurations endpoint #2731

Merged
merged 7 commits into from
Jun 4, 2024
Merged

21442 Legal API - Add filter to configurations endpoint #2731

merged 7 commits into from
Jun 4, 2024

Conversation

AimeeGao
Copy link
Collaborator

@AimeeGao AimeeGao commented May 30, 2024 •
edited
Loading

Issue #: /bcgov/entity#21442

Description of changes:

  • Add filter query param to GET /configurations endpoint to retrieve configuration items by name
  • Add unit tests
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@AimeeGao AimeeGao self-assigned this May 30, 2024
JazzarKarim
JazzarKarim approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from Argus' comment, LGTM

@AimeeGao AimeeGao force-pushed the 21442-add-filters-to-configurations branch from 0f7ca76 to 1e83c3a Compare May 31, 2024 16:00
@JazzarKarim JazzarKarim mentioned this pull request Jun 3, 2024
Merged
@AimeeGao AimeeGao force-pushed the 21442-add-filters-to-configurations branch from 1e83c3a to 4c8eb6d Compare June 4, 2024 15:40
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

chenhongjing
chenhongjing approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@chenhongjing chenhongjing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐱 Just suggestion, some tests you wrote can be combined by using @pytest.mark.parametrize

Maybe wait for Argus to do final approval before you can merge it?

@AimeeGao
Copy link
Collaborator Author

AimeeGao commented Jun 4, 2024

LGTM 🐱 Just suggestion, some tests you wrote can be combined by using @pytest.mark.parametrize

Maybe wait for Argus to do final approval before you can merge it?

Thanks for your feedback. Will be updated next time.

@AimeeGao AimeeGao merged commit 25992fe into bcgov:main Jun 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eason-pan-bc eason-pan-bc eason-pan-bc left review comments

@JazzarKarim JazzarKarim JazzarKarim approved these changes

@chenhongjing chenhongjing chenhongjing approved these changes

@argush3 argush3 argush3 approved these changes

@kzdev420 kzdev420 Awaiting requested review from kzdev420

@leodube-aot leodube-aot Awaiting requested review from leodube-aot

Assignees

@AimeeGao AimeeGao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AimeeGao @argush3 @chenhongjing @JazzarKarim @eason-pan-bc