Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-5271] Adding function to view past versions of a file on front end #2576

Merged
merged 19 commits into from
Jul 10, 2023
Merged

[MDS-5271] Adding function to view past versions of a file on front end #2576

merged 19 commits into from
Jul 10, 2023

Conversation

asinn134
Copy link
Collaborator

@asinn134 asinn134 commented Jun 27, 2023 •
edited
Loading

Objective

  • Adds ability to view current and old versions of files in document table
  • Adds icon to indicate to viewer how many past versions of a file exist
  • Adds DocumentAction component for action drop down in document table, so far only has Download file, and Open in Document Viewer
  • Only adjusted the tables found in Major Project's Final Application tab, and the matchChildColumnsToParent prop is used to differentiate between the current structure of document tables and this PR's structure.

MDS-5271

image

image

image

matbusby-fw
matbusby-fw previously approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It's not strictly necessary (especially on biggish PRs like this), but whenever possible, let's try to convert the .js files worked on within a PR to .ts/.tsx and class based components to functional. I think that will be the best path forward to slowly updating everything.

simensma-fresh
simensma-fresh requested changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@simensma-fresh simensma-fresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little suggestion, otherwise looks good!

services/core-web/src/components/common/DocumentTable.js Outdated Show resolved Hide resolved
simensma-fresh
simensma-fresh previously approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@simensma-fresh simensma-fresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@asinn134 asinn134 closed this Jun 29, 2023
@asinn134 asinn134 reopened this Jun 30, 2023
henryoforeh-dev
henryoforeh-dev previously approved these changes Jul 7, 2023
View reviewed changes
@asinn134 asinn134 merged commit 2c6efbc into develop Jul 10, 2023
@asinn134 asinn134 deleted the mds-5271-expandingrows-table branch July 10, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryoforeh-dev henryoforeh-dev henryoforeh-dev approved these changes

@taraepp taraepp taraepp approved these changes

@simensma-fresh simensma-fresh Awaiting requested review from simensma-fresh

@matbusby-fw matbusby-fw Awaiting requested review from matbusby-fw

@isuru-aot isuru-aot Awaiting requested review from isuru-aot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asinn134 @simensma-fresh @henryoforeh-dev @matbusby-fw @taraepp