Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5465] Enable Cypress tests and add y-padding style #2641

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

matbusby-fw
Copy link
Collaborator

The previously commented out Cypress test commands have been un-commented out to enable running of integration tests. Test commands include 'cy.login()', 'cy.visit(url/mines)' and URL assertion statement in index.cy.ts, and authentication process in commands.ts.

Since it was having similar failures to what is now on test, this will hopefully allow recreation of the issue.

Noticed a missing style in scss added that back in.

Objective

MDS-5465

The previously commented out Cypress test commands have been un-commented out to enable running of integration tests. Test commands include 'cy.login()', 'cy.visit(`url/mines`)' and URL assertion statement in `index.cy.ts`, and authentication process in `commands.ts`.

In addition, a new y-padding modifier class has been added in `layout.scss` for design adjustments. This class applies the same padding to the top and bottom of an element, improving the visual balance of layout elements.
@matbusby-fw matbusby-fw added the 🚧 WIP This is work in progress code that may change significantly. label Aug 30, 2023
@matbusby-fw matbusby-fw merged commit 082fadc into develop Aug 30, 2023
8 checks passed
@matbusby-fw matbusby-fw deleted the mds5465-file-version-fix branch August 30, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 WIP This is work in progress code that may change significantly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants