-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment logging #130
Merged
Merged
Segment logging #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng of message in one Kibana document
gwdonogh
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all looks good. Nice job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements segment-specific HL7 message logging. Segment logging functionality allows us to log only specific segments of an HL7 message, omitting the segments that are known to contain PII. The proposed configuration allows for customization of segments both per-environment and per-service.
In the current proposed configuration, the MSH, ZCA, and ZCB segments are logged in the dev, tr1, vs1, vc2, and vc1 environments and no segments are logged in the production environment. Once we have confirmed which segments we want to log in production, we can update the list of strings in all the
appsettings.prd.json
files atHL7v2Authorization.LoggableSegments
.This feature requires code changes, so it should be tested in all environments before being scheduled for a deployment in production. Use the
PPM API - RFC Template for Code Deployments
document as a reference for the change deployment process.