-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIDP-958 Remaining Access Request pages + Endorsements New UX #556
Merged
AdityaMantripragada
merged 23 commits into
develop
from
feature/pidp-958-endorsement-ux
Jul 12, 2024
Merged
PIDP-958 Remaining Access Request pages + Endorsements New UX #556
AdityaMantripragada
merged 23 commits into
develop
from
feature/pidp-958-endorsement-ux
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaMantripragada
requested review from
Paahn,
james-hollinger and
kakarlavinodkumar
July 2, 2024 23:15
AdityaMantripragada
added
the
Ready For Review
PR is code-complete (or very close) and only needs some review and/or manual testing
label
Jul 2, 2024
Paahn
reviewed
Jul 4, 2024
...nization-info/pages/endorsements/components/endorsement-card/endorsement-card.component.html
Outdated
Show resolved
Hide resolved
Paahn
reviewed
Jul 10, 2024
workspace/apps/pidp/src/app/features/access/pages/bc-provider-edit/bc-provider-edit.page.html
Outdated
Show resolved
Hide resolved
...s/pidp/src/app/features/access/pages/ms-teams-clinic-member/ms-teams-clinic-member.page.html
Show resolved
Hide resolved
...dp/src/app/features/access/pages/ms-teams-privacy-officer/ms-teams-privacy-officer.page.html
Show resolved
Hide resolved
...space/apps/pidp/src/app/features/organization-info/pages/endorsements/endorsements.page.html
Outdated
Show resolved
Hide resolved
Paahn
changed the title
Feature/pidp 958 endorsement ux
PIDP-958 Remaining Access Request pages + Endorsements New UX
Jul 10, 2024
Paahn
reviewed
Jul 11, 2024
...space/apps/pidp/src/app/features/organization-info/pages/endorsements/endorsements.page.scss
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Paahn
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ready For Review
PR is code-complete (or very close) and only needs some review and/or manual testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.