Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the redundant code #1464

Closed
wants to merge 4 commits into from
Closed

remove the redundant code #1464

wants to merge 4 commits into from

Conversation

eve-git
Copy link
Collaborator

@eve-git eve-git commented Jun 7, 2024

*Issue #:*21593

Description of changes:
Removed nrStatus.value = state before the state is updated in the database. nrStatus is updated when retrieving NR information from the database.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@eve-git
Copy link
Collaborator Author

eve-git commented Jun 7, 2024

/gcbrun

@eve-git
Copy link
Collaborator Author

eve-git commented Jun 7, 2024

/gcbrun

Copy link
Collaborator

@EPortman EPortman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the changes of removing 'nrStatus.value = state' in updateNRState locally and no longer get the "nro_service_account" flashes up in banner after clicking "Examine" button.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants