16636 Update Extrapro NR flow (continued) #655
Conversation
There was a problem hiding this comment.
This component, with slots for the previous code, was a good idea at the time, but with the new way of navigating it was becoming "messy" to have knowledge of the flows in the parent (Search) and here, so I moved what was in here back into the parent.
As we near the end of the flow changes, there may be an opportunity(ies) to break out some code into sub-components, but I see nothing obvious right now that wouldn't increase, instead of decrease, complexity.
One thing to watch for is to keep row/col layout in a single file. For example, I think we shouldn't have row declarations in Search and columns in sub-components. Instead, all rows/cols should be in Search, and the sub-components can be the column contents.
There was a problem hiding this comment.
I see. Makes so much sense Sev. Having it with slots previously provided limitations on how flexible we could've been with the flows. Cool!
| @@ -2,6 +2,7 @@ | |||
| <v-select | |||
| class="request-action-select" | |||
| filled | |||
| hide-details="auto" | |||
There was a problem hiding this comment.
This keeps the component "short" unless some detail messages (errors) need to be shown. This is to prevent excess bottom whitespace, which we sometimes absorb with negative bottom margins -- but this is better.
| @@ -18,7 +18,7 @@ | |||
| <v-col v-if="showDesignationSelect" :class="{'pl-3': !isMobile}" cols="12" lg="3"> | |||
| <v-select filled | |||
| :items="designationOptions" | |||
| label="Enter designation" | |||
| label="Select a Designation" | |||
There was a problem hiding this comment.
To be consistent with Search page (as per uxpin).
| @@ -3,7 +3,7 @@ import { EntityI } from '@/interfaces/models' | |||
|
|
|||
| export const EntityTypesBcData: EntityI[] = [ | |||
| { | |||
| text: 'Sole proprietorship', | |||
| text: 'Sole Proprietorship', | |||
There was a problem hiding this comment.
The uxpin showed some entity types in title case, so I changed them all over.
- moved Bullets Colin Link into Search - hide details in misc components - renamed getIsConversion -> isConversion - refactored layout in Search - added Federal bullets - moved isXXX computed to getters.ts - updated misc computed - title-cased entity names (per uxpin) - updated search test suite
| <v-col cols="12" class="pt-0 font-weight-bold h6"> | ||
| <v-container fluid id="search-container" class="copy-normal pt-10 px-10 pb-12"> | ||
| <v-row> | ||
| <v-col cols="12" class="font-weight-bold h6"> |
|
|
||
| <v-row class="mt-6"> |
There was a problem hiding this comment.
I got rid of the "second row". Most sections here are simply columns, which automatically wrap or stack depending on screen width. Eg,
| content-class="top-tooltip" | ||
| transition="fade-transition" | ||
| :disabled="isMobile" | ||
| <!-- Type of Business, only when an entity type is selected (or federal) --> |
There was a problem hiding this comment.
Moved here from previous sub-component.
| return false | ||
| } | ||
|
|
||
| get showBusinessLookup () { | ||
| if (this.isChangeName) return true | ||
| if (this.isAlteration) return true | ||
| if (this.isConversion) return true |
There was a problem hiding this comment.
A conversion is an alteration, but the NR Request Action Code is CNV so I renamed this getter accordingly.
severinbeauvais
requested review from
JazzarKarim,
kzdev420,
ketaki-deodhar and
leodube-aot
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-655-fw1o16m2.web.app |
severinbeauvais
merged commit 26361c9
into
bcgov:feature-way-of-navigating
- moved Bullets Colin Link into Search - hide details in misc components - renamed getIsConversion -> isConversion - refactored layout in Search - added Federal bullets - moved isXXX computed to getters.ts - updated misc computed - title-cased entity names (per uxpin) - updated search test suite
- moved Bullets Colin Link into Search - hide details in misc components - renamed getIsConversion -> isConversion - refactored layout in Search - added Federal bullets - moved isXXX computed to getters.ts - updated misc computed - title-cased entity names (per uxpin) - updated search test suite
- moved Bullets Colin Link into Search - hide details in misc components - renamed getIsConversion -> isConversion - refactored layout in Search - added Federal bullets - moved isXXX computed to getters.ts - updated misc computed - title-cased entity names (per uxpin) - updated search test suite
- moved Bullets Colin Link into Search - hide details in misc components - renamed getIsConversion -> isConversion - refactored layout in Search - added Federal bullets - moved isXXX computed to getters.ts - updated misc computed - title-cased entity names (per uxpin) - updated search test suite
- moved Bullets Colin Link into Search - hide details in misc components - renamed getIsConversion -> isConversion - refactored layout in Search - added Federal bullets - moved isXXX computed to getters.ts - updated misc computed - title-cased entity names (per uxpin) - updated search test suite
Issue #: bcgov/entity#16636
Description of changes:
- app version = 5.0.25
- moved Bullets Colin Link into Search
- hide details in misc components
- renamed getIsConversion -> isConversion
- refactored layout in Search
- added Federal bullets
- moved isXXX computed to getters.ts
- updated misc computed
- title-cased entity names (per uxpin)
- updated search test suite
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).