hide name check result container when name is too short #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-657-8w8uwoxl.web.app |
|
Could this fix be applied to the Way of Navigating feature branch instead? (Feature branch is planned for deployment in October.) The feature branch is in active development at the moment and any changes to main branch may conflict, or at least will require some careful rebasing/refactoring. Therefore, I'd prefer to merge this PR into the feature branch if possible. |
bolyachevets
force-pushed
the
16998-name-check
branch
from
9d56616
to
5f58183
Compare
bolyachevets
force-pushed
the
16998-name-check
branch
from
5f58183
to
b680f1e
Compare
severinbeauvais
approved these changes
Aug 24, 2023
|
/gcbrun |
severinbeauvais
merged commit a0b77b1
into
bcgov:feature-way-of-navigating
5 checks passed
|
Temporary Url for review: https://namerequest-dev--pr-657-8w8uwoxl.web.app |
severinbeauvais
pushed a commit
to severinbeauvais/namerequest
that referenced
this pull request
Aug 29, 2023
* hide name check when name is too short * update version
JazzarKarim
pushed a commit
to JazzarKarim/namerequest
that referenced
this pull request
Sep 8, 2023
* hide name check when name is too short * update version
JazzarKarim
pushed a commit
that referenced
this pull request
Sep 11, 2023
* hide name check when name is too short * update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #: /bcgov/entity/16998
*Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).