18532 - AM Button Implementation #748
Conversation
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app |
severinbeauvais
changed the title
There was a problem hiding this comment.
I think you need to update something in App.vue as well, somewhere around here: fixed now
Line 261 in 4ca645b
This is in case the user was initially not logged in and was redirected to log in, to resume the flow when they return to Namerequest UI.
There was a problem hiding this comment.
You also need to update existing-request-display.vue to handle your second "todo checkbox" in your ticket. fixed now
It should look like this, except "Amalgamate Now":
This ties in to my comment about updating getBusinessRequest().
If this doesn't fit in your current ticket's estimate, let me know and we'll create a new ticket for it.
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app |
|
James, I'm pressing on the amalgamate now button after an NR has been approved, but I don't see anything happening. Shouldn't we be getting an HTTP 400 error for now at least since the BE hasn't been setup yet? |
|
Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app |
|
James, please indicate here (or better, in the ticket), what testing you've done, including:
Thanks. |
|
/gcbrun |
| header: { accountId, name }, | ||
| incorporationApplication: { | ||
| nameRequest: { legalType, nrNumber } | ||
| if (nr.request_action_cd === 'AML') { |
There was a problem hiding this comment.
This looks correct now - thanks.
If you're ever in here again -- perish the thought! -- use NrRequestActionCodes.AMALGAMATE instead of "AML". (This isn't worth a new commit on its own.)
|
Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app |
|
James, are you ready to merge this, or do you want to do a bit more testing first? |
jamespaologarcia
requested review from
Rajandeep98,
rarmitag,
stevenc987 and
eve-git
@jamespaologarcia , I wrote this on Nov 29. What's your answer please? |
Hi, I sent the PR link to Omid. I'm waiting for confirmation before I merge it. |
James replied: "All good from my side. I tested the cases you pointed out to me." |
Issue #: /bcgov/entity#18532
Added implementation for amalgamate now button.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).