Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 84 create cap records #98

Merged
merged 14 commits into from
May 7, 2024
Merged

Conversation

franTarkenton
Copy link
Member

@franTarkenton franTarkenton commented Apr 30, 2024

Modify the create alert end point so that it also creates the associated end cap events, and the associated tests that go along with that logic

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

pytest.ini now contains an env var called USE_POSTGRES_FOR_TESTS.  If this parameter is set to true it will use the locally deployed postgres database.
- if for some reason, we revert to using flyway can retrieve these files from quickstart
* needed to cleanup the model for the pydantic serialization to work
@franTarkenton franTarkenton marked this pull request as ready for review May 3, 2024 22:20
@franTarkenton franTarkenton merged commit eee096a into main May 7, 2024
13 checks passed
@franTarkenton franTarkenton deleted the feat/84-create-cap-records branch May 7, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant