VDYP-306 Veteran Layer Processing for VRIStart #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with a defined height.
smithkm
force-pushed
the
feature/VDYP-306
branch
4 times, most recently
from
84f84eb
to
201b432
Compare
smithkm
commented
Aug 23, 2024
There was a problem hiding this comment.
I accidentally committed originals from a merge in a previous PR. Here I'm removing them.
smithkm
commented
Aug 23, 2024
There was a problem hiding this comment.
I accidentally committed originals from a merge in a previous PR. Here I'm removing them.
smithkm
force-pushed
the
feature/VDYP-306
branch
from
201b432
to
d359c68
Compare
mjunkin
reviewed
Aug 27, 2024
vdyp-lib/vdyp-common/src/main/java/ca/bc/gov/nrs/vdyp/application/VdypStartApplication.java
Show resolved
Hide resolved
vdyp-lib/vdyp-vri/src/main/java/ca/bc/gov/nrs/vdyp/vri/VriStart.java
Outdated
Show resolved
Hide resolved
vdyp-lib/vdyp-vri/src/main/java/ca/bc/gov/nrs/vdyp/vri/VriStart.java
Outdated
Show resolved
Hide resolved
vdyp-lib/vdyp-vri/src/main/java/ca/bc/gov/nrs/vdyp/vri/VriStart.java
Outdated
Show resolved
Hide resolved
| treesPerHectare = tphSum; | ||
| } | ||
|
|
||
| return inputTreesPerHectare; |
There was a problem hiding this comment.
There's this check (after the call to YUCV) in the original code - not sure where it is in your code:
if ( abs (TPHinput- TPH(0,4))/TPHinput .gt. 0.0005)
LOW_DQ = .true.
if (LOW_DQ) IER= -1
|
mjunkin
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.