Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUP-Admin -> FAQ page can be accessed by non system admin users #335

Open
manuji opened this issue Jan 26, 2024 · 5 comments
Open

DUP-Admin -> FAQ page can be accessed by non system admin users #335

manuji opened this issue Jan 26, 2024 · 5 comments
Assignees

Comments

@manuji
Copy link

manuji commented Jan 26, 2024

Parent ticket: #325

Scenario:

Expected:

  • Only system admin users should be able to access the FAQ page.

Issue:

  • The FAQ page can be accessed by nonsystem admin users from the direct link
  • For non-system admin users, the link to navigate to the FQA page is displayed and through that link the page is accessible.
Screen.Recording.2024-01-25.at.5.49.44.PM.mov

Note to QA: There are several non-admin users.

Christopher-walsh22 added a commit to Christopher-walsh22/parks-reso-admin that referenced this issue Jan 29, 2024
Christopher-walsh22 added a commit that referenced this issue Jan 30, 2024
* Fixes for #335 and #336

* Update test as FAQ card will now always be displayed

* Remove line break
@manuji
Copy link
Author

manuji commented Jan 30, 2024

Tested on TEST: Pending

  • Verified that the FAQ page on the Admin system is only accessible by the "sysAdmin" role.
  • But the link to FAQ page is displayed on both Left nav and the Home page for the non-subsAdmin users.

@JLWade & @ndelraye, shouldn't we hide the links if they are not relevant to the logged-in user? Please let us know your thoughts.

Fyi @Christopher-walsh22

@JLWade
Copy link
Contributor

JLWade commented Jan 30, 2024

@manuji yes that's correct - FAQ link should be hidden to non-sys admin users

@JLWade
Copy link
Contributor

JLWade commented Jan 30, 2024

suggest moving back to to-do to resolve :)

@manuji
Copy link
Author

manuji commented Jan 30, 2024

@Christopher-walsh22 , assigning this back to you to update the navigation panel and the Home page cards.

@manuji
Copy link
Author

manuji commented Feb 1, 2024

Tested on TEST: Passed

  • Verified that this issue has been fixed.
  • Pending deployment to PROD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants